- Apr 01, 2019
-
-
Brendan O'Leary 🐢 authored
-
- Mar 26, 2019
-
-
Brendan O'Leary 🐢 authored
-
Brendan O'Leary 🐢 authored
-
Brendan O'Leary 🐢 authored
-
- Mar 22, 2019
-
-
Tomasz Maczukin authored
* 11-9-stable: Update CHANGELOG for v11.9.0 Update CHANGELOG for v11.9.0 Update CHANGELOG for v11.9.0-rc2 Merge branch 'restore-pprof-debug-endpoint' into 'master' Merge branch 'fix-project-dir-masking' into 'master'
-
Tomasz Maczukin authored
-
Tomasz Maczukin authored
-
Steve Azzopardi authored
Remove unnecessary log alias for logrus inport See merge request gitlab-org/gitlab-runner!1256
-
- Mar 21, 2019
-
-
Tomasz Maczukin authored
Some time ago [we had a discussion](https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/934#note_91891281) about why we're aliasing some of the imports of `github.com/sirupsen/logrus` package with a `log` alias. At that moment we've been doing that in 17 from 68 cases when logrus was imported in Runners codebase. The conclusion was this aliasing is unnecessary, because: - we relay on logrus interface so much that moving to another logging library will be not so simple as switching the import name; - we're totally not consistent in the alias usage which makes the code even more messy. Three GitLab Runner maintainers agreeded hat there is no reason to use the aliasing and that we should just use `logrus` everywhere. But no action was don since then. The cleanup was left for a future. Unfortunately, because GitLab Runner is one of our biggest projects in Go, for some people it becomes a source of suggestions of how certain things should be handled. For example here is a discussion in a new project that creates a go-based tool for our Serverless integration: https://gitlab.com/gitlab-org/gitlabktl/merge_requests/9#note_152472275 The most important statement is: > perhaps we could leave it as is since it is how we are exposing logrus in the runner project Because we already know that it should be changed and others start to look on Runner's code to find good patterns, let's finally cleanup the `log` aliasing mess.
-
Alessio Caiazza authored
Get windows tag for helper image Closes #3895 See merge request gitlab-org/gitlab-runner!1239
-
Steve Azzopardi authored
-
Steve Azzopardi authored
We are checking if the image tag is `x86_64-xxx` for any kind of runtime the test is running, which is not true because if the test is run on arm it would fail.
-
Steve Azzopardi authored
One day we can end up with a windows server version of `Windows Server 2019 Datacenter Evaluation Version 1809 (OS Build 18033.316)` which would end up picking the wrong image since it would match the wrong version. regexp was not used to the sake of performance and to make thins a bit simplier/more readable.
-
Alessio Caiazza authored
Add retryable err type See merge request gitlab-org/gitlab-runner!1215
-
Alessio Caiazza authored
Update codeclimate version See merge request gitlab-org/gitlab-runner!1252
-
- Mar 20, 2019
-
-
Steve Azzopardi authored
Merge branch '3895-get-os-dependent-pre-build-image-for-docker-executor-tm-updates' into '3895-get-os-dependent-pre-build-image-for-docker-executor' Updates for "Get windows tag for helper image " See merge request gitlab-org/gitlab-runner!1254
-
Tomasz Maczukin authored
-
- Mar 19, 2019
-
-
Tomasz Maczukin authored
-
Tomasz Maczukin authored
Rename the linuxHelperImage and windowsHelperImage as well
-
Tomasz Maczukin authored
-
Tomasz Maczukin authored
-
Tomasz Maczukin authored
executor_docker.go already have almost 1.5K lines. Since we're creating new abstraction, let's move it to a separated file.
-
Tomasz Maczukin authored
DRY's the code a little, removing the recurring `case` entry where only the operating system string changes. Instead a loop over a version map is added. In case when we will start supporting another Windows version, we will only need to update tha map.
-
Tomasz Maczukin authored
-
Steve Azzopardi authored
OSType, has values like `windows` and `linux` which is not helpful for us to determine the windows version. OperatingSystem has values like `Windows Server 2019 Datacenter Evaluation Version 1809 (OS Build 17763.379)` which has the version we need to determine which helper image to use.
-
Steve Azzopardi authored
The original implementation was checking if the arch from docker was an emptry string or not.
-
Steve Azzopardi authored
-
Steve Azzopardi authored
-
Steve Azzopardi authored
helperImageVersion is getting the windows version not the helper image version itself.
-
Steve Azzopardi authored
-
Steve Azzopardi authored
-
Steve Azzopardi authored
-
Steve Azzopardi authored
-
Steve Azzopardi authored
-
Steve Azzopardi authored
This implementation is specific for Docker running on Linux and not Unix itself.
-
Steve Azzopardi authored
Instead of checking runtime of `gitlab-runner` check the docker runtime to get the correct helperImage interface. Only load docker images from local disk when helper image implementation supports it, by checking `IsSupportingLocalImport()`
-
Steve Azzopardi authored
Create the reviewers guide base document See merge request gitlab-org/gitlab-runner!1233
-
Tomasz Maczukin authored
-
Tomasz Maczukin authored
-
Tomasz Maczukin authored
-