Forum | Documentation | Website | Blog

Skip to content
Snippets Groups Projects
Commit e2046be9 authored by Will Deacon's avatar Will Deacon Committed by Jiri Slaby
Browse files

arm64: vdso: work-around broken ELF toolchains in Makefile


commit 6f1a6ae8 upstream.

When building the kernel with a bare-metal (ELF) toolchain, the -shared
option may not be passed down to collect2, resulting in silent corruption
of the vDSO image (in particular, the DYNAMIC section is omitted).

The effect of this corruption is that the dynamic linker fails to find
the vDSO symbols and libc is instead used for the syscalls that we
intended to optimise (e.g. gettimeofday). Functionally, there is no
issue as the sigreturn trampoline is still intact and located by the
kernel.

This patch fixes the problem by explicitly passing -shared to the linker
when building the vDSO.

Reported-by: default avatarSzabolcs Nagy <Szabolcs.Nagy@arm.com>
Reported-by: default avatarJames Greenlaigh <james.greenhalgh@arm.com>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent 60b51980
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment