tomoyo-reduce-mmap_sem-hold-for-mm-exe_file-checkpatch-fixes
Sumeone needs to buy a tab key.
WARNING: please, no spaces at the start of a line
#29: FILE: security/tomoyo/util.c:951:
+ struct file *exe_file;$
WARNING: please, no spaces at the start of a line
#30: FILE: security/tomoyo/util.c:952:
+ const char *cp;$
WARNING: please, no spaces at the start of a line
#31: FILE: security/tomoyo/util.c:953:
+ struct mm_struct *mm = current->mm;$
WARNING: please, no spaces at the start of a line
#40: FILE: security/tomoyo/util.c:955:
+ if (!mm)$
WARNING: suspect code indent for conditional statements (7, 15)
#40: FILE: security/tomoyo/util.c:955:
+ if (!mm)
+ return NULL;
WARNING: please, no spaces at the start of a line
#42: FILE: security/tomoyo/util.c:957:
+ exe_file = get_mm_exe_file(mm);$
WARNING: please, no spaces at the start of a line
#43: FILE: security/tomoyo/util.c:958:
+ if (!exe_file)$
WARNING: suspect code indent for conditional statements (7, 15)
#43: FILE: security/tomoyo/util.c:958:
+ if (!exe_file)
+ return NULL;
WARNING: please, no spaces at the start of a line
#46: FILE: security/tomoyo/util.c:961:
+ cp = tomoyo_realpath_from_path(&exe_file->f_path);$
WARNING: please, no spaces at the start of a line
#47: FILE: security/tomoyo/util.c:962:
+ fput(exe_file);$
WARNING: please, no spaces at the start of a line
#48: FILE: security/tomoyo/util.c:963:
+ return cp;$
total: 0 errors, 11 warnings, 28 lines checked
./patches/tomoyo-reduce-mmap_sem-hold-for-mm-exe_file.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Davidlohr Bueso <dbueso@suse.de>
Cc: James Morris <jmorris@namei.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by:
Andrew Morton <akpm@linux-foundation.org>
Loading
Please register or sign in to comment