- Jul 05, 2022
-
-
Abramo Bagnara authored
- explicit with a cast the destination bitwidth of left shift ensuring to not break DTS Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
- Apr 22, 2022
-
-
Abramo Bagnara authored
- added explicit cast to void when returned value is expectedly ignored Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
- Apr 21, 2022
-
-
Abramo Bagnara authored
- fixed the code generator so to use "more" parameter name consistently Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Abramo Bagnara authored
- fixed the code generator so to obtain congruent parameter names Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
- Apr 07, 2022
-
-
Abramo Bagnara authored
- avoid to convert pointers to incomplete type using the pointer to first item Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Abramo Bagnara authored
- added missing braces Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Abramo Bagnara authored
- avoid to use undefined macros in #if expressions Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Abramo Bagnara authored
- made explicit the copied data type Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Abramo Bagnara authored
- avoided dead stores Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Gerard Marull-Paretas authored
New Sphinx version (or docutils) has slightly changed the output format for code documentation directives. These changes try to mimic previous behavior, even though it does not achieve 100% equal result. In some cases the new default style does not require further tweaks, and in some others styling as before is not possible. Signed-off-by:
Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
-
Gerard Marull-Paretas authored
breathe: for simplicity, require versions > 4.30 (lower versions have known issues, so do not take risks). Sphinx: start requiring versions >=4.x. Keep with compatible versions, since Sphinx major updrages can easily break extensions, themes, etc. sphinx_rtd_theme: upgrade to >=1.x. Again, keep with compatible versions since we have style customizations that can likely break on major upgrades. pygments: Allow any version >=2.9 (version that introduced DT support). We do not have strong compatibility requirements here. sphinx-notfound-page: Remove any requirements, we do not have strong requirements for this one. Signed-off-by:
Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
-
- Apr 06, 2022
-
-
Abramo Bagnara authored
In particular: - use always the same parameter names in every redeclarations Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Abramo Bagnara authored
In particular: - added requested parentheses verifying the lack of ambiguities Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Abramo Bagnara authored
In particular: - added missing ARG_UNUSED - added void to cast where ARG_UNUSED macro is not available Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Abramo Bagnara authored
In particular: - avoid to obtain an unwanted null pointer Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
- Mar 29, 2022
-
-
Abramo Bagnara authored
In particular: - avoid to use assignment expression value Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Gerard Marull-Paretas authored
Split Bluetooth tests workflow into 2 steps: - One that runs the actual tests and stored results - A second one that fecthes and uploads tests results Signed-off-by:
Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
-
Gerard Marull-Paretas authored
With this setting enabled, Git credentials are not kept after checkout. Credentials are not necessary after the checkout step since we do not do any further manual push/pull operations. Signed-off-by:
Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
-
Abramo Bagnara authored
In particular: - avoided unneeded conversions from integer to pointer Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Abramo Bagnara authored
In particular: - moved switch clause so to avoid backward jump Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Abramo Bagnara authored
In particular: - added missing parenthesis around macro argument expansion Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Abramo Bagnara authored
In particular: - moved declarations so to not conflict with static inline stubs Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
- Mar 23, 2022
-
-
Abramo Bagnara authored
In particular: - avoided ++/-- on volatile - avoided to have more than one ++/-- in for third clause - moved ++/-- before or after the value use - avoided pointless ++/-- - replaced consecutive ++ with a single += Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
- Mar 14, 2022
-
-
Abramo Bagnara authored
In particular: - modified parameter types to receive a const pointer when a non-const pointer is not needed - avoided redundant casts - used cast to const pointer when a non-const pointer is not needed Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Abramo Bagnara authored
In particual: - avoided to assign string literals to non-const char * Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
- Mar 01, 2022
-
-
Abramo Bagnara authored
In particular: - use bool when the data nature is Boolean; - use explicit comparison with 0 or NULL; - avoid mixing signed and unsigned integers in computations and comparisons; - avoid mixing enumerations with integers: when this is unavoidable, always convert enums to integers and not the other way around; - avoid mixing characters with integers; - ensure computations are done in the destination precision; - added /*? comments when the developer intentions are not clear; - added U suffix to unsigned constants (except for the CONFIG_* macro constants, as they cannot be changed and then their use as unsigned constants should be prefixed with a cast). Violations for rules 10.1, 10.2, 10.3, 10.4, 10.5, 10.6, 10.7, 10.8, 11.7, 12.2, 14.4 and 16.7 in the reference builds have been reduced from 67818 to 60. The commit cannot be divided on a per-rule basis due to numerous cross-dependencies between changes. Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
- Feb 22, 2022
-
-
Michał Barnaś authored
This commit changes the shell parameter name to meet the MISRA check requirements. Signed-off-by:
Michał Barnaś <mb@semihalf.com>
-
- Feb 08, 2022
-
-
Flavio Ceolin authored
Fixes violations code guideline related with essential types rules: - use explicit comparison with 0 or NULL - ensure computations are done in the destination precision - avoid mixing enumerations with integers: when this is unavoidable, always convert enums to integers and not the other way around - avoid mixing signed and unsigned integers in computations and comparisons Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Flavio Ceolin authored
Fixes violations code guideline related with essential types rules: - Ensure computations are done in the destination precision - Avoid mixing characters with integers Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Flavio Ceolin authored
Fixes violations code guideline related with essential types rules: - Avoid mixing characters with integers - Ensure computations are done in the destination precision Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Flavio Ceolin authored
Fixes violations code guideline related with essential types rules: - Ensure computations are done in the destination precision - Avoid mixing signed and unsigned integers in computations and comparisons Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Flavio Ceolin authored
Fixes violations code guideline related with essential types rules: - Avoid mixing signed and unsigned integers in computations and comparisons - Ensure computations are done in the destination precision Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Flavio Ceolin authored
Fixes violations code guideline related with essential types rules: - Use explicit comparison with 0 or NULL to avoid boolean promotion Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Flavio Ceolin authored
Fixes violations code guideline related with essential types rules: - Ensure computations are done in the destination precision - Avoid mixing signed and unsigned integers in computations and comparisons Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Flavio Ceolin authored
Fixes violations code guideline related with essential types rules: - Avoid promotion from boolean to integer Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Flavio Ceolin authored
Fixes violations code guideline related with essential types rules: - avoid mixing signed and unsigned integers in computations and comparisons Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Flavio Ceolin authored
Fixes violations code guideline related with essential types rules: - use bool when the data nature is Boolean Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Flavio Ceolin authored
Fixes violations code guideline related with essential types rules: - ensure computations are done in the destination precision - avoid mixing signed and unsigned integers in computations and comparisons Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-
Flavio Ceolin authored
Explicitly returning int instead of promoting a boolean. Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com>
-
Flavio Ceolin authored
Avoid mixing signed and unsigned integers in computations and comparisons. Signed-off-by:
Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:
Abramo Bagnara <abramo.bagnara@bugseng.com>
-